Created
January 26, 2022 10:41
-
-
Save przemuh/5b50c238353c0d12507676f83878c503 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <!-- | |
| These comments are just guidelines | |
| not a strict set of rules to follow. | |
| --> | |
| **Jira**: | |
| **Design**: | |
| <!-- | |
| Add screenshot in case of a visual change: | |
| * before and after screenshot if it's a change | |
| * just a screenshot if it's something new | |
| * link to Figma is "nice to have" | |
| --> | |
| ### Feature branches: | |
| - | |
| - | |
| ### Description: | |
| <!-- | |
| * include business context of change, | |
| * technical reasoning behind develoment, | |
| * keep it short, big description is in Jira | |
| --> | |
| ### Checklist: | |
| <!-- | |
| * Friendly reminder for self-check. | |
| * Not all of them are obligatory but should be helpful | |
| * before passing the PR to final review. | |
| * Feel free to add or remove options that you need. | |
| --> | |
| - [ ] Self-review | |
| - [ ] Amplitude events | |
| - [ ] Unit tests | |
| - [ ] Components tests | |
| - [ ] E2E Tests | |
| - [ ] Consistent with a decision log | |
| - [ ] Design review | |
| ### Possible regressions: | |
| - | |
| - | |
| - <!-- | |
| * focus on areas which might cause regression | |
| * update your Jira task, because tester might not see list in this PR | |
| --> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment