Skip to content

Instantly share code, notes, and snippets.

@ivanrvpereira

ivanrvpereira/model_mixins.py

Forked from glarrain/model_mixins.py
Created July 17, 2014 22:33
Show Gist options
  • Save ivanrvpereira/02c77aa2065f910e96b0 to your computer and use it in GitHub Desktop.
Save ivanrvpereira/02c77aa2065f910e96b0 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
model_mixins.py
class ValidateModelMixin(object):
"""Make :meth:`save` call :meth:`full_clean`.
.. warning:
This should be the left-most mixin/super-class of a model.
Do you think Django models ``save`` method will validate all fields
(i.e. call ``full_clean``) before saving or any time at all? Wrong!
I discovered this awful truth when I couldn't understand why
a model object with an email field (without `blank=True`) could be
saved with an empty string as email address.
More info:
* "Why doesn't django's model.save() call full clean?"
http://stackoverflow.com/questions/4441539/
* "Model docs imply that ModelForm will call Model.full_clean(),
but it won't."
https://code.djangoproject.com/ticket/13100
"""
def save(self, *args, **kwargs):
"""Call :meth:`full_clean` before saving."""
self.full_clean()
super(ValidateModelMixin, self).save(*args, **kwargs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment