Pull Requests became popular for two reasons:
- Asynchronous communication. Developers can review and respond at any time, allowing them to continue development without interruption and review PRs when they come to a natural pause in their flow.
- Quality Assurance. Reviewing and testing code before it hits the target branch ensures that the target branch stays clean.
- Authoring
- Keep them small: it's very tempting to rewrite, refactor, boy scout and reformat the code as you develop but in general, it's best not to do it all at once.
- Perform a Self-Review: although it's very tempting to just dump your changes in a PR and let other people find the mistakes, create a draft PR and do a full review yourself. You can also use this “self-review” to point things out to your reviewers.
- Create a meaningful title: keep the title short and meaningful and avoid titles generated from the b