fishme · July 4, 2018 06:57
diff --git a/Plullrequests b/Plullrequests
 **General**
 - [ ] Are all vars used somewhere?
 - [ ] Do the vars have properly cased, and meaningful names?
 - [ ] Style looks appropriate
 - [ ] No unnecessarily duplicated logic
 - [ ] Code intent is clear upon initial reading
 - [ ] Any code that isn't clear, but is needed, has an effective comment
 - [ ] Are method calls or attribute lookups every called on entities that could be undefined/null?
 - [ ] The functions can appropriately handle unexpected inputs.
 - [ ] Commented *code* has been removed (comments themselves are fine).

 **Angular Specific**

 - [ ] No DOM manipulation is happening inside components
 - [ ] View logic is non-existant or minimal (Business Logic is not in the component)
 - [ ] Among the component logic, there are no good candidates to be extracted into a service
 - [ ] Among all the logic, there are no good candidates to be extracted into a directive
 - [ ] No unneeded components were created.

 **Code**
 - [ ] no .xxx(functions() {}... calls
 - [ ] type defintion in all variables 
 - [ ] let instead var
 - [ ] every class, function and variable have a documentation
 - [ ] no angular.each
 - [ ] no static translations (except error handling)
 - [ ] no static configuration values (in some cases it is necessary)
 - [ ] Error handling catch etc.
 - [ ] compact templates
 - [ ] clear sass code, split pages/app
	General
	- [ ] Are all vars used somewhere?
	- [ ] Do the vars have properly cased, and meaningful names?
	- [ ] Style looks appropriate
	- [ ] No unnecessarily duplicated logic
	- [ ] Code intent is clear upon initial reading
	- [ ] Any code that isn't clear, but is needed, has an effective comment
	- [ ] Are method calls or attribute lookups every called on entities that could be undefined/null?
	- [ ] The functions can appropriately handle unexpected inputs.
	- [ ] Commented code has been removed (comments themselves are fine).

	Angular Specific

	- [ ] No DOM manipulation is happening inside components
	- [ ] View logic is non-existant or minimal (Business Logic is not in the component)
	- [ ] Among the component logic, there are no good candidates to be extracted into a service
	- [ ] Among all the logic, there are no good candidates to be extracted into a directive
	- [ ] No unneeded components were created.

	Code
	- [ ] no .xxx(functions() {}... calls
	- [ ] type defintion in all variables
	- [ ] let instead var
	- [ ] every class, function and variable have a documentation
	- [ ] no angular.each
	- [ ] no static translations (except error handling)
	- [ ] no static configuration values (in some cases it is necessary)
	- [ ] Error handling catch etc.
	- [ ] compact templates
	- [ ] clear sass code, split pages/app