- Followup on cosmos/cosmos-sdk#2372
-
-
Save cwgoes/d543134430c001c9d5418e3e3fc24ea9 to your computer and use it in GitHub Desktop.
I have some confusions about this PR: cosmos/cosmos-sdk#2255
I found there is no delay in validator set power calculation.
Besides, you have this comment
// That's fine since this is just used to filter unbonding delegations & redelegations.
distributionHeight := infractionHeight - stake.ValidatorUpdateDelay
So I think the main impact of this PR is to slashing period, and there is no impact to validator set power calculation. Am I right?
cosmos/cosmos-sdk#2405
Previously, I had asked you why we need complete operation for redelegate and unbond. I remember that your concerns of automatic completion is the performance. Now the PR has merged, and do we have tested the performance?
For fee distrubution, currently it doesn't support inflation token distribution. Will it support this in the future?
cosmos/cosmos-sdk#2405
Previously, I had asked you why we need complete operation for redelegate and unbond. I remember that your concerns of automatic completion is the performance. Now the PR has merged, and do we have tested the performance?
we could spend some time talking about the simplified staking logic
I have some confusions about this PR: cosmos/cosmos-sdk#2255
I found there is no delay in validator set power calculation.
Besides, you have this comment// That's fine since this is just used to filter unbonding delegations & redelegations. distributionHeight := infractionHeight - stake.ValidatorUpdateDelay
So I think the main impact of this PR is to slashing period, and there is no impact to validator set power calculation. Am I right?
I agree with you
Let's discuss this PR: cosmos/cosmos-sdk#2474
I noticed that the mint module has been implemented. But I have a confusion about ProcessProvisions. The inflation tokens has not been added to loosenToken. To my understand, the loosenToken should contains all the stake token existing in the blockchain. So the inflation tokens should be added to loosenToken.
Is my understanding correctly? If so, does this mean there is a bug in mint moudle?
In unbonding and redelegating, why the truncated token should be burned?
https://github.com/cosmos/cosmos-sdk/blob/7f43860ca95a2375840490d99ff1b05a0907961f/x/stake/keeper/delegation.go#L567
Besides, in fee distribution module, the truncated fee tokens are added to community pool:
https://github.com/cosmos/cosmos-sdk/blob/7f43860ca95a2375840490d99ff1b05a0907961f/x/distribution/keeper/delegation.go#L99
I rememder that in previous implementation, allocating collected token to global pool and validator pool took place in endblock. However, now it is in beginBlocker. Why did we make this change? Does this change have some additional consideration?
Suppose there are three validators(A, B, C), and I have only one delegation to A. Then I launch a redelegation from A to B. Before, the completion of this redelegation, can I launch another redelegation from B to C?
Currently, the IBC is premature. Soon the main net will be launch. Once the IBC is mature, we have to upgrade gaiad. Then how do we start main network with historical data?
What is the main purpose of upgrade tendermint to 0.26? I have check the related PR: cosmos/cosmos-sdk#2633.
The main changes contains
- Replace UnmarshalBinary with UnmarshalBinaryLengthPrefixed
- Refactor merkle proof
However, I didn't found any issues about unmarshal and query proof. Does this upgrade fix some known issues?
I'd love to develop some tools similar to https://gist.github.com/zmanian/88fdd41421d363d11adbcf98d3367a4c
love some advice on how cosmos/cosmos-sdk#2422 will have effects