Prior to opening your pull request, try not to suck.
If you are seeking review/feedback before meeting this criteria, meet as much as you can and TAP a DRAFT PR.
- Remove unecessary debugging,
Ctrl+F
fordebugger
andconsole.log
, remove unecessary noise - Review & improve comments,
Ctrl+F
for//
and/**
, pretend you're not you and see if they make sense - TS/JS Lint passes
- TS/JS Tests pass
- Optionally run the build locally
- DRY blah blah, but don't overdo it, review may help with DRY/refactoring
- Check if scope changed too much, if so, consider breaking up
- At this point, write meaningful line items in the PR for the code & UI changes made
- Try to wait until CI is green before opening
- Expect to get wrecked anyways