Created
March 9, 2019 07:53
-
-
Save bjankord/4ac237205d314b5dab884a0a90754bc4 to your computer and use it in GitHub Desktop.
Frame.jsx diff
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ packages/terra-form-select/src/_Frame.jsx:207 @ class Frame extends React.Component { | |
className: cx('search-input', { 'is-hidden': Util.shouldHideSearch(this.props, this.state) }), | |
}; | |
+ const selected = 'selected!'; | |
switch (variant) { | |
case Variants.TAG: | |
case Variants.MULTIPLE: | |
@ packages/terra-form-select/src/_Frame.jsx:224 @ class Frame extends React.Component { | |
case Variants.COMBOBOX: | |
return <div className={cx('content')}><input {...inputAttrs} value={hasSearchChanged ? searchValue : display} /></div>; | |
default: | |
- return display ? <span id={displayId}>{display}</span> : <div id={placeholderId} className={cx('placeholder')}>{placeholder || '\xa0'}</div>; | |
+ return display ? ( | |
+ <React.Fragment> | |
+ {/* this id mapping is probably not needed in safari, need to test ios and jaws without it<span id={displayId}> */} | |
+ <div> | |
+ {display} | |
+ {/* <span className={cx('visually-hidden-component')}>{` ${selected}`}</span> */} | |
+ </div> | |
+ </React.Fragment> | |
+ ) : <div id={placeholderId} className={cx('placeholder')}>{placeholder || '\xa0'}</div>; | |
} | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment