Skip to content

Instantly share code, notes, and snippets.

@bhardwajRahul

bhardwajRahul/TechChallengeReview_52_20190208.md

Forked from blademirage/TechChallengeReview_52_20190208.md
Created February 20, 2019 11:24
Show Gist options
  • Save bhardwajRahul/e5bfa43364324c2a373861641251ff3a to your computer and use it in GitHub Desktop.
Save bhardwajRahul/e5bfa43364324c2a373861641251ff3a to your computer and use it in GitHub Desktop.
Download ZIP
Tech Challenge Review 52 (2019-02-08)
Raw
TechChallengeReview_52_20190208.md

Considered this submission as a PASS case.

Submitted tech challenge:

Pros:

  • API endpoints naming follows problem statement.
  • Clean and tidy code.
  • Demonstrated well use of existing frameworks/libraries.
  • All endpoints working as expected.
  • All test cases can be executed successfully.

Cons:

  • Docker containers started with error messages under Ubuntu 18.04, but works fine under macOs 10.14.1.
  • Test cases did not cover fail cases.
  • Did not provide error message if the the Google Map API key is missing (submitted solution still able to receive API request and return normal error responds).

Testing environment 1 (docker container started with error messages):

  • Droplet(instance) at DigitalOcean SGP1
  • Ubuntu 18.04 x64
  • Docker CE Client/Server v18.06.1-ce
  • Docker-Compose v1.22.0

Testing environment 2 (docker container started with error messages):

  • MacBook Pro (2017)
  • macOs 10.14.1
  • Docker version 18.09.0
  • Docker-Compose v1.23.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment