Created
June 14, 2021 20:33
-
-
Save MP-C/da4be75816b91faaad865e41da6305de to your computer and use it in GitHub Desktop.
Security: XSS attack and data validation - implemented with React and Express
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const express = require('express'); | |
| const session = require('express-session'); | |
| const bodyParser = require('body-parser'); | |
| const cache = require('memory-cache'); | |
| const passport = require('passport'); | |
| const { check, validationResult } = require('express-validator/check'); | |
| // app.integration.spec.js | |
| const request = require('supertest'); | |
| const app = require('./app'); | |
| const agent = request.agent(app); | |
| describe('app', () => { | |
| describe('when authenticated', () => { | |
| beforeEach(async () => { | |
| await agent | |
| .post('/login') | |
| .send('username=randombrandon&password=randompassword'); | |
| }); | |
| describe('POST /messages', () => { | |
| describe('with non-empty content', () => { | |
| describe('with JavaScript code in personalWebsiteURL', () => { | |
| it('responds with error', async done => { | |
| // … | |
| done(); | |
| }); | |
| }); | |
| describe('with HTTP URL in personalWebsiteURL', () => { | |
| it('responds with success', async done => { | |
| // … | |
| done(); | |
| }); | |
| }); | |
| }); | |
| }); | |
| }); | |
| }); | |
| const getErrorAsObject = errors => | |
| errors.reduce((errorObject, { param, msg }) => { | |
| errorObject[param] = msg; | |
| return errorObject; | |
| }, {}); | |
| require('./authentication-setup'); | |
| const { createMessage, getMessages, seedUsers } = require('./data-interface'); | |
| global.cache = cache; | |
| seedUsers(); | |
| const app = express() | |
| .use(bodyParser.urlencoded({ extended: true })) | |
| .use( | |
| session({ | |
| secret: 'secretKeyThatShouldBeInEnvironmentConfig', | |
| resave: false, | |
| saveUninitialized: true, | |
| }) | |
| ) | |
| .use(passport.initialize()) | |
| .use(passport.session()); | |
| // Requests that do not require authentication | |
| app | |
| .get('/messages', (_, res) => res.send({ messages: getMessages() })) | |
| .post('/login', (req, res, next) => { | |
| passport.authenticate('local', (error, user) => { | |
| if (error) { | |
| return res.status(401).send({ error }); | |
| } | |
| return req.login(user, _ => res.redirect('/me')); | |
| })(req, res, next); | |
| }); | |
| // Requests that require authentication | |
| app | |
| .use((req, res, next) => { | |
| if (req.isAuthenticated()) { | |
| return next(); | |
| } | |
| return res.sendStatus(401); | |
| }) | |
| .get('/me', (req, res) => res.send(req.user)) | |
| .post( | |
| '/messages', | |
| [ | |
| check('content') | |
| .not() | |
| .isEmpty() | |
| .withMessage('Content may not be empty'), | |
| check('personalWebsiteURL') | |
| .isURL({ require_protocol: true }) | |
| .withMessage( | |
| 'URL must be a valid HTTP URL starting with http:// or https://' | |
| ), | |
| ], | |
| (req, res) => { | |
| const { content, personalWebsiteURL } = req.body; | |
| const errors = validationResult(req).array(); | |
| if (errors.length) { | |
| return res.status(400).send({ errors: getErrorAsObject(errors) }); | |
| } | |
| createMessage(req.user.username, content, personalWebsiteURL); | |
| return res.status(201).send({ messages: getMessages() }); | |
| } | |
| ) | |
| app.listen( | |
| 4000, | |
| () => { | |
| console.log('Error running express server.'); | |
| }, | |
| () => { | |
| console.log('Express server listening on port 4000.'); | |
| } | |
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment