Created
February 12, 2013 14:50
-
-
Save tacksoo/4770349 to your computer and use it in GitHub Desktop.
Example of an ineffective use of the LinkedList
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import java.util.ArrayList; | |
import java.util.Iterator; | |
import java.util.LinkedList; | |
public class LinkedListFail { | |
/* | |
* This is slow | |
*/ | |
public static ArrayList<Integer> removeEvensInArrayList(ArrayList<Integer> list) { | |
for (int i = 0; i < list.size(); i++) | |
{ | |
if (list.get(i) % 2 == 0) | |
list.remove(i); | |
} | |
return list; | |
} | |
/* | |
* This is slower | |
*/ | |
public static LinkedList<Integer> removeEvensInLinkedList(LinkedList<Integer> list) { | |
for (int i = 0; i < list.size(); i++) | |
{ | |
if (list.get(i) % 2 == 0) | |
list.remove(i); | |
} | |
return list; | |
} | |
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import java.util.ArrayList; | |
import java.util.Arrays; | |
import java.util.LinkedList; | |
import java.util.Random; | |
import org.junit.Before; | |
import org.junit.Test; | |
public class LinkedListFailTest { | |
private ArrayList<Integer> al; | |
private LinkedList<Integer> ll; | |
@Before | |
public void setUp() throws Exception { | |
// Integer [] nums = new Integer[]{1,2,3,4,5,6,7,8,9,10}; | |
Integer[] nums = new Integer[100000]; | |
Random r = new Random(); | |
for (int i = 0; i < nums.length; i++) { | |
nums[i] = r.nextInt(1000000); | |
} | |
al = new ArrayList<Integer>(Arrays.asList(nums)); | |
ll = new LinkedList<Integer>(Arrays.asList(nums)); | |
} | |
@Test | |
public void testRemoveEvensInLinkedList() { | |
LinkedListFail.removeEvensInLinkedList(ll); | |
} | |
@Test | |
public void testRemoveEvensInArrayList() { | |
LinkedListFail.removeEvensInArrayList(al); | |
} | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment